RobotWebTools / rclnodejs / 40483451824

91%

push

github

Synchronize executor restarts with callbacks still in flight (#1664)

## Summary

Prevent executor restarts from racing with callbacks that have not yet returned. Keep old callbacks from acknowledging new work, and delay the restarted worker until earlier callback execution and cleanup finish.

## Changes

- Track in-flight callbacks in `DoWork()` and `SpinOnce()`.
- Use RAII guards to update callback counts and notify waiting workers on exit.
- Associate work completion with the original async handle so stale callbacks cannot clear a restarted executor's pending-work flag.
- Wait for earlier callbacks to finish before initializing the restarted worker's wait set.
- Allow stop requests to interrupt that wait, preventing deadlocks during repeated stop/restart operations.
- Add seven regression tests covering restart, entity mutation, and stopping again from ordinary callbacks, `uncaughtException` handlers, and `spinOnce()` callbacks.

Fix: #1665

2320 of 2715 branches covered (85.45%)

Branch coverage included in aggregate %.

18087 of 19670 relevant lines covered (91.95%)

252.78 hits per line