RobotWebTools / rclnodejs / 40480593675

91%

Build Type

push

github

Committed by web-flow

Commit Message

Isolate executor errors and guarantee exception-path cleanup (#1662)

## Summary

Make executor error reporting instance-local and thread-safe. Contain callback exceptions at the libuv boundary, ensure cleanup runs on failure paths, and keep JavaScript spinning state consistent with native teardown.

## Changes

- Replace global exception storage with mutex-protected, per-executor error storage.
- Report JavaScript callback exceptions through Node.js exception handling.
- Treat unexpected native callback exceptions as fatal errors.
- Report undelivered worker errors during shutdown alongside cleanup failures.
- Finalize `spinOnce()` wait sets on exceptional exits.
- Synchronize JavaScript spinning state with native executor state, even when stop throws.
- Clear synchronized handles only after the executor is stopped.
- Add regression tests for error reporting, restart after errors, and non-Error thrown values.
- Document worker and cleanup errors from `stop()`.

Fix: ##1663

Coverage Stats

2316 of 2711 branches covered (85.43%)

Branch coverage included in aggregate %.

6 of 11 new or added lines in 1 file covered. (54.55%)

1 existing line in 1 file now uncovered.

18087 of 19670 relevant lines covered (91.95%)

252.84 hits per line