zwave-js / zwave-js-ui / 39453582082

17%

push

github

fix(ui): keep network graph filters when clicking the background (#4868)

## Problem

In the network graph, set a Locations or Nodes filter, then click an
empty part of the graph (or click the controller, or close the node
properties dialog). The graph goes back to showing every node and the
filters are ignored, even though they are still set in the panel.

Back in 2023 this was called expected, because clicking the background
was the only way back to the overview. Users in the thread (three over
two years) pointed out the problem with that: once you filter by a room
and click a node, there is no way back to *that room's* overview without
re-applying the filter. Clicking the background should return to the
filtered overview, the same view you get right after setting the filter.

The concern about reaching the full overview still holds with this
change: clear the filters (each autocomplete is `clearable`) and the
graph shows all nodes again, the same way it does today when filters
change.

## Fix

`handleSelectNode` in `src/components/custom/ZwaveGraph.vue` treats an
empty selection as "show all". Now, when the selection is empty and a
Locations or Nodes filter has entries, it falls back to `filteredNodes`
and selects them in vis-network too. That gives the same state the
filter watcher sets up through `setSelection`.

All paths that end in an empty selection go through this one spot:
background click (vis `select` event), clicking the controller,
`clearSelection()` (closing the node dialog in `Mesh.vue`), and removing
the last selected node.

The check looks only at the filter lists, not the "invert" toggles. With
an empty list, invert has no effect in `filteredNodes`. Counting it
would shrink the view to the controller alone.

## Overlap with #4858

#4858 (floorplan) changes `src/views/Mesh.vue` and adds new graph files
(`FloorPlanMap.vue`, `MeshLegend.vue`, `MeshHealthCard.vue`,
`src/lib/meshView.js`). It does not change `ZwaveGraph.vue`, so the two... (continued)

671 of 4570 branches covered (14.68%)

Branch coverage included in aggregate %.

1178 of 7055 relevant lines covered (16.7%)

2.84 hits per line