zwave-js / zwave-js-ui
18%

DEFAULT BRANCH: master
Repo Added
Token mus2r2yYRz7XGYVesP5DKNJXitjqkrcyd regen
Build 2514 Last
Files 70
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 18.308%. Remained the same
22772360183

push

github

web-flow 
fix(ui): display 'unknown' for CC values with null value (#4582)

CC values with a literal `null` value (indicating an unknown state) were
displayed as the string `"null"` in the UI instead of `"unknown"`.

## Root cause

JavaScript's `typeof null === 'object'` quirk caused `null` to fall into
the object-serialization branch of `parsedValue`, returning
`JSON.stringify(null)` → the string `"null"`. The template's
`parsedValue == null` guard never triggered since `"null"` is a non-null
string.

## Fix

Added an explicit `=== null` guard before the `typeof === 'object'`
check in `parsedValue`:

```js
// ValueId.vue — parsedValue getter
if (this.modelValue.newValue === null) {
    return null  // template: parsedValue == null → displays 'unknown'
} else if (typeof this.modelValue.newValue === 'object') {
    return JSON.stringify(this.modelValue.newValue)
}
```

Returning `null` from the getter lets the existing template condition
`parsedValue == null ? 'unknown' : ...` handle it correctly, consistent
with how `undefined` values are already treated.

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>CC values with value `null` shown as `null`</issue_title>
> <issue_description>When a CC value has the literal value `null`
(meaning known to be in an unknown state), the UI shows `null` for this
value instead.
> We should display `unknown` like we do when the value is
`undefined`.</issue_description>
> 
> ## Comments on the Issue (you are @copilot in this section)
> 
> <comments>
> </comments>
> 


</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes zwave-js/zwave-js-ui#4581

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for
you](https://github.com/zwave-js/zwave-js-ui/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%... (continued)

334 of 444 branches covered (75.23%)

Branch coverage included in aggregate %.

4054 of 23524 relevant lines covered (17.23%)

1.07 hits per line

Relevant lines Covered
23524 RELEVANT LINES 4054 COVERED LINES
1.07 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
22772360183 master fix(ui): display 'unknown' for CC values with null value (#4582) CC values with a literal `null` value (indicating an unknown state) were displayed as the string `"null"` in the UI instead of `"unknown"`. ## Root cause JavaScript's `typeof null... push web-flow github
18.31
22765474641 copilot/fix-null-cc-value-display Merge be76dae60 into abf1f0612 Pull #4582 web-flow github
18.31
22757619786 master Release 11.14.0 push zwave-js-bot github
18.31
22756228332 master fix: broken ui snackbar Fixes #4574 push robertsLando github
18.31
22755858891 master fix(ui): fix background RSSI chart showing blank on second open (#4576) Opening the controller's background RSSI fullscreen dialog a second time renders a blank chart. The root cause was that on the second open, the async component module is alr... push web-flow github
18.31
22755423550 master feat: make the network graph truly dynamic (#4573) This PR fixes issues with the network graph that have bugged me for a looooong time. It removes the `live view` toggle and `reload graph` button, because they are now no longer necessary. Summar... push web-flow github
18.31
22737123007 copilot/fix-controller-background-rssi-chart Merge a674d6e41 into 88a3f9187 Pull #4576 web-flow github
18.31
22731958657 actually-live-network-map Merge 6efcde63e into 88a3f9187 Pull #4573 web-flow github
18.31
22728854948 feat/playwright-screenshot-tooling Merge 8f6ff97a5 into 88a3f9187 Pull #4579 web-flow github
18.23
22727422046 master feat(ui): validate number inputs against allowed values from config (#4566) ## Implementation Plan: Add Support for Configuration Value `allowed` Field ### Understanding - Z-Wave JS now supports `allowed` field in ValueMetadataNumeric for defini... push web-flow github
18.31
See All Builds (2148)

Badge your Repo: zwave-js-ui

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh