zwave-js / zwave-js-ui
20%

DEFAULT BRANCH: master
Repo Added
Token mus2r2yYRz7XGYVesP5DKNJXitjqkrcyd regen
Build 2648 Last
Files 71
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 19.652% (-0.006%) from 19.658%
27533209408

push

github

web-flow 
fix(ui): keep node index map consistent after node removal (#4667)

## Problem

Closes #4666

After using **Advanced → Failed Node → Replace** to replace a node, the
node's **Status icon stays "Dead"** in the UI even though everything
else works — pinging the node reports success, but the icon won't update
until the browser is refreshed.

## Root cause

The frontend store (`src/stores/base.js`) maintains `nodesMap`, a
`nodeId → index in this.nodes` lookup used by both `getNode` and
`updateNode`. `removeNode` spliced a node out of the array but only
deleted *that* node's `nodesMap` entry:

```js
this.nodesMap.delete(n.id)
this.nodes.splice(index, 1)   // every later node shifts down one slot
```

Splicing shifts every node *after* the removed index down by one, but
their `nodesMap` entries keep pointing at the old (now off-by-one)
index. "Replace Failed Node" removes the old node mid-array and then
re-includes a new one, so afterwards the map is wrong for every later
node. Incoming **partial** `nodeUpdated` status events (alive/dead/ping)
are then `Object.assign`-ed into the *wrong* array slot, so the visible
node's status never changes.

A browser refresh fixes it because `init` → `initNodes` rebuilds the map
from scratch — which also confirms the backend status was correct the
whole time.

## Fix

Rebuild `nodesMap` from the array after the splice, matching the
reassign-a-fresh-`Map` pattern already used by `resetNodes`. This is the
removal-side counterpart to the existing `updateNode` decision (#4639)
to avoid splicing-on-update for the same index-integrity reason.

Frontend-only, one method changed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

410 of 535 branches covered (76.64%)

Branch coverage included in aggregate %.

0 of 8 new or added lines in 1 file covered. (0.0%)

4419 of 24037 relevant lines covered (18.38%)

1.16 hits per line

Relevant lines Covered
24037 RELEVANT LINES 4419 COVERED LINES
1.16 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
27533209408 master fix(ui): keep node index map consistent after node removal (#4667) ## Problem Closes #4666 After using **Advanced → Failed Node → Replace** to replace a node, the node's **Status icon stays "Dead"** in the UI even though everything else works —... push web-flow github
19.65
27533071291 fix/node-status-stale-after-replace Merge fdc8b2191 into dc129d33a Pull #4667 web-flow github
19.65
27340538910 master fix(api): require authentication for the snippet listing endpoint (#4661) push web-flow github
19.66
27340464097 fix/request-body-size-limits Merge daf96d638 into 87c89da15 Pull #4663 web-flow github
19.36
27340449041 fix/snippet-endpoint-auth Merge 20aff2967 into 87c89da15 Pull #4661 web-flow github
19.36
27338933787 fix/session-secret-startup-guard Merge e8b9b462f into 87c89da15 Pull #4664 web-flow github
19.47
27337955825 fix/request-body-size-limits Merge 8fc8cd518 into 87c89da15 Pull #4663 web-flow github
19.36
27337430127 fix/mqtt-payload-numeric-parsing Merge 7bf3af345 into 87c89da15 Pull #4662 web-flow github
19.55
27335081664 master fix(api): apply imported node metadata across wrapped and legacy nodes.json formats (#4636) - [x] Review new actionable PR comments and confirm required follow-up - [x] Check recent CI workflow run status/logs for this branch - [x] Run baseline l... push web-flow github
19.36
27334731684 fix/snippet-endpoint-auth Merge ba5566396 into 82792a9c1 Pull #4661 web-flow github
18.55
See All Builds (2279)

Badge your Repo: zwave-js-ui

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh