zwave-js / zwave-js-ui / 39442394548

17%

push

github

fix: allow turning off boolean actuators on broadcast/multicast nodes (#4751)

## Problem

On **broadcast/multicast** (virtual) nodes, a **Binary Switch** could
only be turned **ON**. There was no way to send OFF. Reported in
discussion #4749.

## Root cause

Virtual nodes never expose readable values: zwave-js sets `readable:
false` on every virtual value. `ValueId.vue` renders every non-readable
boolean as a single button that only sends `true`. So Binary Switch
`targetValue` looked the same as a fire-once trigger, and OFF was
unreachable.

## Fix (UI only)

As suggested in review, this is handled in `ValueId.vue`, without new
backend fields. zwave-js already marks pure buttons in their metadata
with a single `true` state:

```js
states: { true: "Identify" } // Indicator CC
states: { true: "Reset" }    // Meter CC
```

On virtual nodes, a writeable boolean now renders as an On/Off toggle
**unless** it has exactly one `true` state:

| Value (virtual node) | `states` | Control |
| --- | --- | --- |
| Binary Switch `targetValue` | none | On/Off toggle (fixed) |
| Indicator Identify, Meter Reset, Restore previous, Shutoff | `{ true:
... }` | single button (unchanged) |
| Open/Close, level change Up/Down | `{ true: "Start", false: "Stop" }`
| toggle (unchanged) |

Physical nodes are not affected.

633 of 4566 branches covered (13.86%)

Branch coverage included in aggregate %.

1103 of 7044 relevant lines covered (15.66%)

2.31 hits per line