zwave-js / zwave-js-ui / 39556171207

17%

push

github

feat(ui): show min, max and step in value hints (#4865)

## Problem

The value hint only showed min/max when the value also had a default.
Most non-configuration values (levels, setpoints, durations) have no
default, so their range was never shown. The step was never shown at
all, even though the backend already sends it.

## Fix

`help()` in `ValueId.vue` now builds the hint from separate parts:

- `default` when defined
- `min` / `max` when defined (now listed min first, then max)
- `step` when defined and not 1

Examples:

- `Level (Min: 0, max: 99)`
- `(Default: 5, min: 0, max: 255, step: 5)`

Values with states (lists) get no range hint, same as before. Min/max
are skipped when they are equal, since a fixed range tells the user
nothing. A step of 1 is skipped because it is the normal case for
integer values and would add noise to almost every hint.

Configuration values keep their range hint as before.

## Testing

- Checked the hint output for the cases above (with/without default,
step 5 vs 1, min == max, list value) by running `help()` against sample
values with node
- `npm run lint`, `npm run test:ui` pass

Closes #3980

671 of 4570 branches covered (14.68%)

Branch coverage included in aggregate %.

1178 of 7055 relevant lines covered (16.7%)

2.84 hits per line