RobotWebTools / rclnodejs / 39224852259

91%

push

github

Clean up Node.js and Python compatibility code (#1646)

- Remove redundant HTTP capability checks for `flushHeaders`, `unref`, and `closeAllConnections`, which are available on all supported Node.js versions.
- Use `util.inspect.custom` directly for Buffer inspection, removing the legacy string fallback and Node 6 workaround while preserving memory-address output.
- Remove the obsolete Node >12 assertion and Node-API <6 header path without changing Electron memory-cage handling or buffer ownership.
- Simplify the Python helper to select Python 3 explicitly: `python3` on Linux/macOS and `py -3` on Windows, updating both callers.
- Correct the build script and test assertion to use `DistroUtils.DistroId.UNKNOWN` instead of the nonexistent `DistroUtils.UNKNOWN_ID`.
- Preserve historical ROS distro identification and the existing `FUTURE` behavior without adding a supported-distro allowlist.
- Add regression tests for Python command selection, Buffer inspection, and build-script distro detection.
- Update compatibility documentation while retaining the Node.js 20.20.2 minimum, dependencies, compiler settings, browser fallbacks, and CI configuration.

Fix: #1645

2308 of 2704 branches covered (85.36%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

18073 of 19657 relevant lines covered (91.94%)

225.54 hits per line