coreui / coreui-pro / 38899647770

96%

main: 94%

push

github

refactor(ListBox): write the selection of the composite components in one step (#1682)

MultiSelect, Autocomplete and Combobox wrote the selection of their list box by replaying select() and deselect() for each value under a _syncing flag. Each call ran the list box events, which bubble to the page while the panel is open (select all and clear on three options sent 18 of them to document), and redrew the whole list once per value. The list box now takes the selection in one internal step that sends no event and redraws only when the selection or its order changed, so the flag and the per-value loops are gone.

The step keeps one value in single mode, each value once, a disabled or missing value only when the list already holds it, and stops at the selection limit. Combobox setValue() now keeps the order it is given and fills the limit from the start of that list; values already held used to win over new ones, and new ones landed after them. A disabled combobox now takes setValue(), clear() and a form reset, as a disabled native select takes a value from a script; the list box used to refuse them.

7638 of 8194 branches covered (93.21%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 5 files covered. (100.0%)

13198 of 13490 relevant lines covered (97.84%)

1963.42 hits per line