coreui / coreui-pro
96%
main: 94%

LAST BUILD BRANCH: v6-dev
DEFAULT BRANCH: main
Repo Added
Token xWsYEliUZcsKD8YuHf3HMmjnbcE48xXcC regen
Build 2772 Last
Files 82
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v6-dev
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 95.983% (+0.01%) from 95.972%
38050410121

push

github

web-flow 
fix: read a disabled class in the markup as disabled and take back only the one a component added (#1606)

The form components disagreed about what `class="disabled"` on the element means. Combobox, Chip and ChipInput read it as `disabled: true`. Rating and the date and time inputs (SectionInput) removed it at init and gave it back from the class snapshot on dispose, and that snapshot also removed a `.disabled` the page wrote after init. Autocomplete's data API skipped such an element, and a multi select only looked disabled while it kept working.

They now follow one model. A `.disabled` in the markup means `disabled: true` in Combobox, Autocomplete, MultiSelect, ChipInput, Chip, Rating, DateInput and TimeInput. Combobox now reads the class before it sets the native `disabled` of its toggle button, so a button with the class is disabled as well. `dispose()` undoes only the component's own change of the class. The new `toggleHostClass()` util, with JSDoc and specs, sets the class and returns whether the element carried it before the component changed it, or `null` while no such change is in effect. `.readonly` and the size class of Rating stay decided by the options.

SectionInput reads the class only when the options passed in JavaScript leave `disabled` unset. DateRangeInput and the date, date range and time pickers always set it for the fields they build or adopt, so a `.disabled` on an adopted field no longer disables that field while the picker stays enabled.

The Combobox, Autocomplete, MultiSelect, Rating, Date Input and Time Input pages say the class works in markup, and the migration guide describes the change for each. Every new spec fails with its source line reverted, measured by mutation.

A disabled multi select now also disables its native select, given back on dispose. The form leaves it out of validation and of the submitted data, as it does for the other disabled fields, so a required one no longer blocks the submit. A `disabled` att... (continued)

7786 of 8374 branches covered (92.98%)

Branch coverage included in aggregate %.

42 of 43 new or added lines in 8 files covered. (97.67%)

13385 of 13683 relevant lines covered (97.82%)

1635.95 hits per line

Relevant lines Covered
13683 RELEVANT LINES 13385 COVERED LINES
1635.95 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
38050410121 v6-dev fix: read a disabled class in the markup as disabled and take back only the one a component added (#1606) The form components disagreed about what `class="disabled"` on the element means. Combobox, Chip and ChipInput read it as `disabled: true`. ... push web-flow github
95.98
38050374171 fix/host-disabled-class-v6 Merge 4754211ec into d85a6a8d2 Pull #1606 web-flow github
95.98
38049998608 chore/strip-jsdoc-from-builds-v6 Merge da05d68e9 into 0d0246c2d Pull #1607 web-flow github
95.97
38050018561 v6-dev chore(build): drop JSDoc from the built JavaScript (#1607) The unminified bundles (`coreui.js`, `coreui.esm.js`, `coreui.bundle.js`), the per-plugin files in `js/dist` and the util modules in `js/dist/util` kept every JSDoc block from the sources... push web-flow github
95.97
38048878843 fix/host-disabled-class-v6 Merge 5ed4fca83 into 0d0246c2d Pull #1606 web-flow github
95.97
38047375830 fix/host-disabled-class-v6 Merge 812d0d6fe into 0d0246c2d Pull #1606 web-flow github
95.98
38046276030 v6-dev fix(LoadingButton): give the button back its markup on dispose (#1605) `dispose()` left the `btn-loading` class on every button. When it ran while the button was loading it also left `is-loading` and the spinner, and while the button was stopping... push web-flow github
95.97
38046089368 fix/loading-button-dispose-v6 Merge 5986bb873 into 167a2e738 Pull #1605 web-flow github
95.97
38045320360 fix/loading-button-dispose-v6 Merge 2995aad2a into 167a2e738 Pull #1605 web-flow github
95.97
38044851171 v6-dev fix: give form components' hosts back their class attribute on dispose (#1604) Autocomplete, Combobox, MultiSelect, ChipInput, Calendar, Chip, PasswordStrength and OtpInput left `class=""` after `dispose()` on an element that had no class attribu... push web-flow github
95.97
See All Builds (2772)

Badge your Repo: coreui-pro

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh