coreui / coreui-pro
96%
main: 94%

LAST BUILD BRANCH: v6-dev
DEFAULT BRANCH: main
Repo Added
Token xWsYEliUZcsKD8YuHf3HMmjnbcE48xXcC regen
Build 2782 Last
Files 82
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v6-dev
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 95.978%. Remained the same
38082163590

push

github

web-flow 
refactor(NumberInput): drop the MutationObserver and re-read the field when the user reaches for it (#1610)

NumberInput watched its field with a `MutationObserver` so the stepper buttons followed a script that changed `disabled`, `readonly`, `min`, `max` or `step` later. A button left disabled by an old state cannot be pressed, so without the observer the buttons have to re-read the field whenever the user reaches for them.

The observer goes. The buttons are recomputed when the pointer moves over the field's frame, when the frame is pressed with any pointer, and when the field takes focus or the user edits it (unchanged). With a mouse the hover runs before the press, so the first press works. A touch on a button that still looks disabled brings it up to date and the next touch steps. A press never steps a field it should not step, because the step reads the field itself, and a refused press leaves the buttons alone so a button activated by a screen reader keeps focus. `dispose()` now removes every frame listener by namespace.

The docs describe when the buttons catch up, in the Min, max and step section as well. Specs cover focus for each of `min`, `max` and `step`, hover and touch on the frame, a refused press keeping focus, and listeners gone after dispose; each fails under a mutation of its line.

7756 of 8342 branches covered (92.98%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

13364 of 13663 relevant lines covered (97.81%)

1635.76 hits per line

Relevant lines Covered
13663 RELEVANT LINES 13364 COVERED LINES
1635.76 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
38082163590 v6-dev refactor(NumberInput): drop the MutationObserver and re-read the field when the user reaches for it (#1610) NumberInput watched its field with a `MutationObserver` so the stepper buttons followed a script that changed `disabled`, `readonly`, `min... push web-flow github
95.98
38082119712 refactor/number-input-no-observer-v6 Merge c5a531221 into 9531268ff Pull #1610 web-flow github
95.99
38081946581 refactor/number-input-no-observer-v6 Merge f2d257f6d into 9531268ff Pull #1610 web-flow github
95.98
38080956788 refactor/number-input-no-observer-v6 Merge c9bf5c4e5 into 9531268ff Pull #1610 web-flow github
95.99
38080371065 v6-dev fix(PasswordInput): read the field's disabled state when the toggle is used (#1609) The toggle button of a password input took the field's `disabled` state once, at init. A field the page disabled later could still be revealed, through the button... push web-flow github
95.98
38080343834 fix/password-input-disabled-v6 Merge e0b4ffc62 into 7d00c25e1 Pull #1609 web-flow github
95.98
38079586182 fix/password-input-disabled-v6 Merge 424ae4d42 into 7d00c25e1 Pull #1609 web-flow github
95.98
38079312246 v6-dev fix: take the disabled state only from the disabled option (#1608) Combobox, Autocomplete, MultiSelect, ChipSet and ChipInput, Chip, Rating and the date and time inputs (SectionInput) read their disabled state from two places: the `disabled` opti... push web-flow github
95.98
38079289551 fix/disabled-from-option-only-v6 Merge 2756e9bde into 9408281f1 Pull #1608 web-flow github
95.98
38078331839 fix/disabled-from-option-only-v6 Merge a8ca29c3a into 9408281f1 Pull #1608 web-flow github
95.96
See All Builds (2782)

Badge your Repo: coreui-pro

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh