coreui / coreui-pro / 38942933652

96%

main: 94%

push

github

fix(ListBox): one selection for the list box family (#1683)

The list box behind MultiSelect, Autocomplete and Combobox held only part of the selection: disabled values and values the options no longer carried stayed out. A selected disabled option therefore read as unselected in the list, the selection limit was counted on two different sets, and the select all button stuck on mixed once hidden values used up the limit. The list box now takes the whole selection of the component and counts the limit on it, and select all and section labels read the limit through one util, getScopeSelectionState(), that leaves room for values off the screen.

A disabled option or control keeps the user out but not the values the page sets, as a native select does: selected, items marked selected, setItems(), setValue(), value and a form reset can select a disabled option, which the list shows as selected, while select(), toggle() and selectAll() act as the user would. Transfer keeps a disabled item out of the selection to move. A group in items takes disabled: true, Autocomplete disables the options of a disabled group, and MultiSelect selectAll(options) checks its own options for one. The vanilla builders pass the group flag while they build each option, so they keep that walk instead of the new disableGroupOptions() util the React and Vue editions use.

setItems() keeps the values it holds and adds marked items only up to the limit, reporting the first one left out. A section label with nothing left to take is disabled and shows the state of its disabled options. Combobox fires selectionLimit.coreui.combobox and accepts a numeric data-coreui-value. MultiSelect keeps its reset snapshot apart from the selection, adds start values delivered later to it, and survives a change listener that disposes it on every path.

7681 of 8235 branches covered (93.27%)

Branch coverage included in aggregate %.

83 of 83 new or added lines in 7 files covered. (100.0%)

13234 of 13523 relevant lines covered (97.86%)

1969.1 hits per line