coreui / coreui-pro / 38886280031

96%

main: 94%

push

github

fix: ignore key events without a key (#1680)

Chrome autofill and some extensions dispatch keydown and keyup events
that are not KeyboardEvents, so `event.key` is undefined. The MultiSelect
search field and native select, ChipInput and a read-only Rating read
`event.key.length` or `event.key.startsWith()` and threw; ListBox and
ChipSet passed the key to the typeahead buffer, which threw the same
way, as did DateInput through `isTypedKey()`. SearchButton listens on
the whole document, so any such event anywhere on a page with a search
button threw from `toLowerCase()`.

`createTypeaheadBuffer().push()` and `isTypedKey()` now treat a missing
key as a key that types nothing, which also covers the Vue components
that import them. The component handlers check the key with optional
chaining, and the MultiSelect native select handler and the SearchButton
document handlers return early; the native select one returns before it
calls `preventDefault()`, so such an event keeps its default.

7656 of 8214 branches covered (93.21%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 6 files covered. (100.0%)

13222 of 13515 relevant lines covered (97.83%)

1964.26 hits per line