coreui / coreui-pro / 38815270924

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(MultiSelect): keep the selection in one model and render every view from it (#1674)

MultiSelect kept its selection in four places, the model, the list box, the native select and the chips or text, and each action updated some of them by its own path. The external search work in #1670 showed how far they drift once the options stop covering the selection. Every action now builds the next selection and passes it to one writer, which fits it to the mode and the limit, holds each value once and updates the model and validation; one render then writes the list box, the native select, the chips or text, the counters and the header from the model, leaving a focused chip or search box in place. The change events come after the render, so a listener sees the drawn selection.

A page sees one change.coreui.multi-select per action instead of one per option, none when the set of values did not change and none while the component builds; setConfig sends one when it changes the selection and keeps the selection when the config carries neither options nor value. A disabled group passes its disabled flag to its options when they are built, so the list, select all and the counter total agree, and the native select keeps the flag on the optgroup. A selected disabled option renders as a disabled chip, stays through the clear button, deselectAll() and Backspace, is not sent with the form, and its getValue() entry carries disabled: true. A single select whose selection is empty holds the page's value="" placeholder option or none, where the browser used to fall back to the first option.

Coverage Stats

7646 of 8207 branches covered (93.16%)

Branch coverage included in aggregate %.

118 of 119 new or added lines in 1 file covered. (99.16%)

1 existing line in 1 file now uncovered.

13231 of 13524 relevant lines covered (97.83%)

1891.81 hits per line