coreui / coreui-pro / 38764229747

96%

main: 94%

push

github

fix(ListBox, Combobox): keep the selection across setItems, add resetSelectionOnItemsChange (#1671)

* fix(ListBox, Combobox): keep the selection across setItems

setItems dropped every selected value the new items did not carry and fired
change. With external search that lost the pick on every answer, and a single
Combobox also closed its open panel and cleared its value while the user was
typing. The selection is now left alone: a value outside the new items stays
selected, counts against selectionLimit and comes off through deselect, clear
or the next pick in single mode. Only items marked selected join it and fire
change, and a selected value that comes back disabled stays selected.

Combobox remembers the labels of its selected values before each setItems, so
the toggle keeps showing Canada rather than ca once the list no longer carries
the option.

* fix(Combobox): count the selected values the list no longer carries in {total}

Once the selection survives setItems, {total} read from the rendered options alone could fall below {count}, as in 3 of 1. It now counts the union of the listed values and the selected ones.

* feat(ListBox, Combobox): add resetSelectionOnItemsChange for dependent lists

Once setItems stopped pruning, a list that depends on another field kept the
previous field's value: the city of the old country stayed selected and an
item the new list marked selected was ignored in single mode.
resetSelectionOnItemsChange, the items counterpart of the
resetSelectionOnOptionsChange that MultiSelect and Autocomplete carry in React
and Vue, empties the selection when the values of the new items differ and then
takes the marked items. Transfer turns it on for both lists, so a disabled
transfer no longer keeps a checked value that left the items.

Combobox setValue now changes only the difference, so writing back what
getValue returned keeps a value the list does not carry, and the remembered
labels are built in one pass over the options.
... (continued)

7665 of 8231 branches covered (93.12%)

Branch coverage included in aggregate %.

22 of 22 new or added lines in 2 files covered. (100.0%)

13287 of 13577 relevant lines covered (97.86%)

1877.17 hits per line