coreui / coreui-pro / 38757853011

96%

main: 94%

push

github

refactor(Validation): move DateInput and TimeInput onto the FieldValidation controller (#1669)

DateInput, and with it TimeInput, drops its own validation bookkeeping
(server classes, serial, follower, owned value field, the state class it
tracked, and the aria-invalid and description it wrote on the sections)
and describes itself to the FieldValidation controller.

The controller gains ownError for an error of the component's own, which
DateInput has for a date outside minDate, maxDate or disabledDates: it
shows 'invalid' over the given and the reported state without blocking.
It also gains owner for a component that is a part of another: the
owner's state counts as given after the part's own options and state
classes, the owner's error marks the sections invalid and describes them
without drawing the state class unless the part shows 'invalid' itself,
and the owner hears every drop of the state with its serial, a native
reset included. The pickers and DateRangeInput still reach their fields
through _setOwnerState, _setOwnerDismiss and _runAsUser, which now feed
the controller. A commit ends the user's action also when it leaves the
value as it was, as before.

pageDescribed now gets whether the state is 'invalid', and a host it
lists keeps its description and lends the one it carries at the moment.
DateInput keeps the page's description on its group and gives it to the
first section, and to every section while invalid, as it did; the tab
stop of the field moves with the focus, so a later section is where the
user comes back to. writeDescribedBy has no caller left and is removed.

Measured with zlib gzip level 9, as bundlewatch measures, on the build
against 7c0ec7a52: -101 B on coreui.bundle.min.js, -124 B on
coreui.esm.min.js and -107 B on coreui.min.js. Those ceilings come down
by 0.09, 0.12 and 0.10 KiB.

7648 of 8212 branches covered (93.13%)

Branch coverage included in aggregate %.

58 of 58 new or added lines in 2 files covered. (100.0%)

13275 of 13566 relevant lines covered (97.85%)

1875.05 hits per line