coreui / coreui-pro / 38749643787

96%

main: 94%

push

github

feat(Autocomplete, MultiSelect): route typing with globalSearch in both (#1667)

Autocomplete took search as an array, a comma list or 'global', so its two
modes were spelled differently from MultiSelect, where global typing is the
globalSearch option. Autocomplete now takes search: 'external' or null and
gains globalSearch, on by default: a character, Backspace or Delete pressed
on the picker or clear button, or in the panel, moves the focus to the field
and lands there, unless a listener prevented the key.

isTypingKey in util/list-navigation decides what counts as typing for both:
Backspace, Delete, a dead key, or a character other than the space bar; a
press with Meta, or with Ctrl but no Alt, is a shortcut. Ctrl with Alt is
AltGr on Windows and Alt alone is Option on macOS, so a character such as ą
now reaches the MultiSelect search field too, where the old check took any
Ctrl as a shortcut, and the space bar on the Autocomplete picker button
activates it instead of moving the focus.

The Autocomplete host no longer gets tabindex="-1" and keeps a tabindex the
page wrote out of the tab order while it lives; a click on the frame
focuses the field. With search: 'external' the panel opens for the options
the page set even when they do not contain the typed text. ListBox runs no
typeahead while its activeDescendant field takes text.

7679 of 8243 branches covered (93.16%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 3 files covered. (100.0%)

13307 of 13600 relevant lines covered (97.85%)

1822.27 hits per line