coreui / coreui-pro / 38748403504

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(Validation): move RangeSlider and Rating onto the FieldValidation controller (#1668)

RangeSlider and Rating drop their own validation bookkeeping and describe
themselves to the FieldValidation controller. The controller gains
pageDescribed for a page description that does not follow the default:
RangeSlider keeps it on every handle, or on the slider element under a
role the page set, and Rating keeps it on the radio group.

A field that replaces another at the same position goes on with the
follower of that one: followUserValidity gains follow(control), which
moves the listeners on the control and keeps the report, the reset
listeners and a reset whose task has not run yet, and from a reset until
its task runs read() leaves out the report that reset forgets. A rebuild
in a reset listener so forgets the report when the reset goes through and
keeps it when a later listener cancels it, also when the page's listener
runs before the component's. Each reset gets its own task in the
follower too. isReported() goes.

The controller starts following resets at its first refresh, gives each
reset its own task, so a second, cancelled reset in the same task does
not drop the first, and draws nothing after the restore; the followers
draw the restored value right after, and a change listener of the
restore may dispose the component. update() lifts blocks, draws the
class, aria-invalid and the description, and only then puts the block of
a given 'invalid', so a handle blocks with the feedback after the slider
element or, when the description moves to the handles, the one the page
linked through it. dismiss() tells whether it dropped a state, and
RangeSlider and Rating draw only then.

swapStateClass has no caller left and is removed. The wasReported
parameter of followUserValidity stays: CRating in React and Vue carries
the report with it.

Measured with gzip -9 on the build against 6ca03cc77: -571 B on
coreui.bundle.min.js, -572 B on coreui.esm.min.js and ... (continued)

Coverage Stats

7681 of 8246 branches covered (93.15%)

Branch coverage included in aggregate %.

104 of 104 new or added lines in 4 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

13309 of 13602 relevant lines covered (97.85%)

1819.44 hits per line