coreui / coreui-pro / 38743702058

96%

main: 94%

push

github

fix(Autocomplete): name the field by the aria-label on the host (#1666)

ARIA attributes written on the autocomplete element stayed on that element, a frame with no role, so an `aria-label` or `aria-labelledby` there left a field without a visible label unnamed, and an `aria-required` or `aria-errormessage` described nothing. The plugin now moves the attributes that describe the field (`aria-description`, `aria-details`, `aria-errormessage`, `aria-label`, `aria-labelledby`, `aria-placeholder`, `aria-readonly`, `aria-required`) to the input, which is the combobox, before it sets its own; the rest, such as `aria-hidden`, stays on the element. On dispose the element gets each one back, unless the page has written that attribute on it since. The Accessibility section says where the field takes its name from.

Checked in Chromium on the built bundle before the change: `<div data-coreui-autocomplete aria-label="Country">` left the attribute on the frame and no combobox named "Country" in the page.

7757 of 8328 branches covered (93.14%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

13417 of 13710 relevant lines covered (97.86%)

1796.47 hits per line