coreui / coreui-pro / 38736160679

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(Validation): move Autocomplete, ChipInput and OTPInput onto the FieldValidation controller (#1665)

The three components drop their own copies of the validation
bookkeeping and describe themselves to the controller instead. To cover
them the controller gains dismiss(serial) for a component that knows a
change is the user's (Autocomplete keeps dropping only a state given
before the key press started, OTPInput drops it on a typed slot),
serverClassSources for state classes read from several elements
(OTPInput reads the host and every slot), and an aria-describedby
writer that adds and takes back only its own ids, so ids the page or
the component put on a target stay. aria-invalid it overwrote goes back
when a target leaves the list and on dispose, which replaces OTPInput's
own bookkeeping, and a field that leaves the list loses its block. The
message comes from the first focus target when no value field carries
the block (ChipInput with create: false). The describedby tracking is
the controller's own and not markControl's, which keeps the form
utilities' marks on controls the components do not own.

What changes for a page: the description on the host of these three
components now reaches the element that takes the focus, the input or
the first slot, and every slot while the state is invalid, and is added
back to the host on dispose next to what the host carries then. A state
class the page put on the frame stays, a component whose disabled
option is set no longer blocks, and on a native reset the dropped state
is drawn before the value is restored, so the events of the restore
see it gone. The conformance spec loses its known divergences and gains
rules for the description on dispose and for a page's state class.

Measured with gzip -9 on the build against 5b8307525: -466 B
coreui.bundle.min.js, -447 B coreui.esm.min.js, -477 B coreui.min.js.
Those ceilings come down by 0.45, 0.43 and 0.46 KiB, no more than
measured.

Coverage Stats

7755 of 8326 branches covered (93.14%)

Branch coverage included in aggregate %.

119 of 119 new or added lines in 5 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

13405 of 13700 relevant lines covered (97.85%)

1796.78 hits per line