coreui / coreui-pro / 38730865035

96%

main: 94%

push

github

refactor(Validation): keep the validation of MultiSelect and Combobox in one FieldValidation controller (#1662)

Every form component carried its own copy of the same bookkeeping: the
state class from the markup, the state serial, the user validity
followers, the reset listener, the block, the state class and ARIA on
its parts, and the hand-back on dispose. FieldValidation in
util/field-validation.ts now holds all of it. A component describes its
value fields, frames and focus targets, and calls the controller from
its constructor, after a build (refresh), in setConfig (configure), at
a change of the value (change, then update before each change event),
around user actions (runAsUser, or the userAction flag for a list
gesture that spans several callbacks) and in dispose.

MultiSelect and Combobox move onto it, and the validation conformance
spec gives the same result. What changes for a page:
- only a state class the controller added is removed, so a class the
  page put on a frame stays;
- a host that is not a value field gives its aria-describedby to the
  described targets while the component lives (on Combobox the toggle
  is both), read once at build;
- a disabled Combobox no longer sets a custom validity on its value
  field, which was barred from validation anyway;
- the block depends on disabled only, so a stray readonly key no longer
  matters, and a component with its own gate passes canBlock;
- on a native reset the fields forget a report before the value is put
  back, so the change events of the restore see a clean state.
followUserValidity gains isReported(), so a report moves to a field that
replaces another at the same position.

The controller costs more than these two components give back:
measured with gzip -9 on the build against 5798fa47d, +721 B
coreui.bundle.min.js, +749 B coreui.esm.min.js and +749 B
coreui.min.js. Their ceilings go up by those amounts, and each following
migration lowers them again by what it gives back.

7785 of 8358 branches covered (93.14%)

Branch coverage included in aggregate %.

161 of 163 new or added lines in 4 files covered. (98.77%)

13466 of 13762 relevant lines covered (97.85%)

1773.19 hits per line