coreui / coreui-pro / 38727486006

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(ListBox, MultiSelect, Combobox): share resolveCountLabel and fill every placeholder (#1661)

resolveCountLabel lived in util/index, which is not part of the utils/*
surface React and Vue import from, so each kept a copy of its own. It
moves next to getSelectionState in util/selection-state, which the three
components already import, and the React and Vue copies can go.

A string label now has every {count} and {total} replaced, as the option
docs describe it; before, only the first of each was. MultiSelect types
selectedLabel with CountLabel instead of restating the union.

Coverage Stats

7734 of 8309 branches covered (93.08%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

13403 of 13699 relevant lines covered (97.84%)

1772.57 hits per line