coreui / coreui-pro / 38723170435

96%

main: 94%

push

github

fix(MultiSelect, ContextMenu): find the focus inside a shadow root (#1660)

MultiSelect and ContextMenu asked whether the focus was inside them with contains(document.activeElement), and FocusTrap, which only MultiSelect uses, checked the target of a focusin it hears on the document. Inside a shadow root the document reports the host for both, so the answer was always no. MultiSelect then pulled the focus off the option it had just focused (to the panel, or to Select all through the trap) and did not send it home on hide, and ContextMenu left it on the hidden menu when it closed from inside. The components ask containsFocus from util/focus now, which reads the active element of the root the element lives in, and FocusTrap takes the target from composedPath(). New specs open and close both inside a shadow root, the trap gets a focusin from inside one, and two trap specs dispatch focusin from the element instead of faking its target.

Tooltip and DateInput already read that root; they call containsFocus too, with no change in what they do. The calendar asks the same question in more places, including whether the focus fell to the body, and is left for its own change.

7734 of 8309 branches covered (93.08%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 5 files covered. (100.0%)

13405 of 13699 relevant lines covered (97.85%)

1772.54 hits per line