coreui / coreui-pro / 38723053070

96%

main: 94%

push

github

fix(Validation): align the form components with one conformance spec (#1659)

* fix(Validation): align the form components with one conformance spec

Adds a spec that runs MultiSelect, Autocomplete, Combobox, ChipInput,
DateInput, TimeInput, DateRangeInput, DatePicker, TimePicker,
DateRangePicker, OTPInput, RangeSlider and Rating through the same
validation rules. A rule that does not apply to a component is skipped
with the reason in its name.

MultiSelect, Combobox, ChipInput, DateInput and TimeInput forgot a state
class from the markup before setConfig type-checked its options, so a
rejected setConfig still dropped the state and dispose no longer gave the
class back. The type check now runs first.

MultiSelect redrew the frame and aria-invalid of a dropped state only
after its change event. Dropping the state now redraws it.

* test(MultiSelect): keep the selection through a rejected setConfig with a value

* fix(MultiSelect): draw the state of the new selection at each change event

The state drawn during change.coreui.multi-select now comes from the
selection after the option flips, not before: emptying a reported
required field shows it invalid, filling it shows no state. setConfig
stores the checked config before deselectAll(), so a state a change
listener gives meanwhile is kept.

The conformance spec now checks both range ends, the whole component for
a stale class or aria-invalid, the elements by identity, the page
description and its order, aria at the change events, a field a
validation already reported, a rejected setConfig that mixes the state
with a wrong option, and the page's custom validity through dispose.

7733 of 8307 branches covered (93.09%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 4 files covered. (100.0%)

13403 of 13699 relevant lines covered (97.84%)

1771.43 hits per line