coreui / coreui-pro / 38389015907

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(MultiSelect): fill the selection to its limit through a shared util (#1636)

Add fillSelection to util/selection-state: it adds candidates in order until the selection holds as many values as the limit allows and returns the values, the ones it added and the first one it refused. The React and Vue editions take it from @coreui/coreui-pro/utils/selection-state.

MultiSelect selectAll and selectFiltered use it instead of their own loops. They now report selectionLimit only when the limit refused an option, and fire change only for the options they add. Disabled groups are still skipped at any depth, the first option with a value still gives the text, and single mode still ends on the last enabled option.

Coverage Stats

7691 of 8270 branches covered (93.0%)

Branch coverage included in aggregate %.

32 of 32 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

13335 of 13631 relevant lines covered (97.83%)

1713.92 hits per line