coreui / coreui-pro / 38389691885

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(Popover): keep a focus-triggered popover open while its content is used (#1634)

A tooltip or popover with `trigger: 'focus'` closed as soon as the trigger
lost focus, so pressing inside it to select text closed it before the
selection could start, and a control inside it only worked when that control
took focus first.

While such a tip is shown it now watches the document. A press that starts
in the trigger or in a tip, its own or a nested one, leaves the focusout it
causes without effect, for mouse and touch alike, until the press ends in a
click or is cancelled. Once focus has left both, the tip closes on the next
click outside or when focus moves to another element. A click inside, such
as the one a label forwards to its control, never closes it, and nothing
closes it while focus is still on the trigger or in the tip. A tip opened
from code or by hover is left alone. The listeners exist only for the focus
trigger and are removed on hide and dispose.

Coverage Stats

7719 of 8297 branches covered (93.03%)

Branch coverage included in aggregate %.

34 of 34 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

13367 of 13665 relevant lines covered (97.82%)

1712.91 hits per line