coreui / coreui-pro / 38305365092

96%

main: 94%

push

github

fix(Drawer, Offcanvas): close when the stylesheet lays them out inline (#1629)

Two rules lay a drawer or offcanvas out inline: a responsive variant
(.drawer-lg, no bare .drawer) past its breakpoint in the window, and a
plain .drawer inside a .navbar-expand-* past the navbar's own breakpoint,
since every navbar is a query container. The components only closed on a
window resize, so a navbar that widened on its own (a sidebar collapsing,
a resizable column) left the native dialog open in the top layer over a
navbar that had already laid it out inline. Measured in Chromium: both
stayed open at position absolute until a window resize event.

DialogBase gains _initResizeObserver(), which Drawer and Offcanvas call
from their constructors: a plain drawer inside an expanding navbar observes
the navbar and, on the next frame after it resizes, hides itself when it is
open and no longer position: fixed. A check that lands during a show or
hide transition waits for it to end instead of being refused by hide().
dispose() disconnects the observer and cancels a pending frame, and a
missing element no longer reaches closest(). The navbar docs say an open
drawer closes once the navbar grows past its breakpoint, whatever widened
it.

The window resize handler now looks only at responsive variants, the
drawers the window can lay out inline; a plain drawer elsewhere is never
inline, so author CSS that positions it some other way no longer closes it
on a resize. The selectors match any class token starting with "drawer-"
(or "offcanvas-") instead of a substring, so a tier from a custom
$breakpoints map still matches while an unrelated <dialog class="my-drawer">
no longer gets an instance and closes.

Unit specs cover the window resize for a plain, a custom-tier and an
unrelated dialog, the navbar widening with the drawer inline and with it
still fixed, which drawers observe, a missing element, the disconnect and a
pending frame cancelled on dispose; a visual spec widens ... (continued)

7679 of 8269 branches covered (92.86%)

Branch coverage included in aggregate %.

27 of 30 new or added lines in 3 files covered. (90.0%)

13311 of 13613 relevant lines covered (97.78%)

1712.23 hits per line