coreui / coreui-pro / 38368854676

96%

main: 94%

push

github

refactor(Autocomplete, MultiSelect): read the option tree through a shared util (#1630)

ComboboxBase, Autocomplete and MultiSelect flattened groups, filtered
out the disabled options and told groups apart in code of their own,
and the React and Vue packages carried their own copies of the same
helpers. `util/option-tree` now holds `isOptionGroup`,
`flattenOptions`, `getOptionLabel`, `getOptionValue`,
`isOptionDisabled`, `getSelectableOptions` and `findOptionByLabel`,
with JSDoc and a spec, and ships as
`@coreui/coreui-pro/utils/option-tree`. The three components tell
groups apart and list options through it, and ListBox and Transfer read
item values through `getOptionValue`. The per-file `list-box.js` and
`transfer.js` builds now also need `util/option-tree.js` loaded before
them.

Behaviour does not change. The specs of the private `_flattenOptions`
and `_isOptionGroup` moved to the util spec. Looking an option up by
value stays in ComboboxBase: React and Vue compare values strictly and
vanilla as strings, and that difference is still open. `coreui.min.js`
shrinks by 306 B, 18 B gzip.

7684 of 8271 branches covered (92.9%)

Branch coverage included in aggregate %.

31 of 31 new or added lines in 6 files covered. (100.0%)

13317 of 13619 relevant lines covered (97.78%)

1711.13 hits per line