coreui / coreui-pro / 38239071750

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(DateInput): make the section field DateInput, with TimeInput as its time preset (#1614)

SectionInput was an abstract base under two subclasses that differed only
in configuration. DateInput added `type: 'date' | 'datetime'`, `seconds`
and the "Date and time input" name; TimeInput fixed the time layout, the
time-string parsing and `timeChange`. The section engine already knew all
three layouts, so the base is now DateInput itself:

- DateInput takes `type: 'date' | 'datetime' | 'time'`. On `'time'` it
  renders the hour and minute sections (plus seconds and AM/PM where they
  apply), parses `'14:30'` and names itself "Time input" while the default
  name is kept.
- TimeInput extends DateInput with its own NAME, data API, default
  `ariaLabel` and `timeChange`, and `_configAfterMerge` fixes `type` to
  `'time'`, so a `type` passed to it changes nothing. TimeInputConfig,
  and with it the TimeInput constructor and setConfig, leave `type` out,
  and TimeInput names itself from `ariaLabel` alone, as before.
- A `type` outside the three keeps the "Date input" name, as before.
- DatePicker sets its field's type from `timepicker` itself, so a `type`
  option given to the picker no longer reaches the field.
- section-input.ts is gone; the pickers type their field options with
  DateInputConfig.

TimeInput keeps its options, events, markup and accessible name. Its
Default now carries `type: 'time'`, and importing it loads DateInput too,
with DateInput's data API and jQuery plugin.

date-input.ts is section-input.ts moved (`git diff -M -B` shows the
rename); the old 104-line DateInput subclass folded into it.

Bundles get smaller, gzip -9 against v6-dev: coreui.min.js -73 B,
coreui.esm.min.js -50 B, coreui.bundle.min.js -67 B, coreui.js -45 B,
coreui.esm.js -17 B, coreui.bundle.js -45 B.

Coverage Stats

7753 of 8338 branches covered (92.98%)

Branch coverage included in aggregate %.

406 of 414 new or added lines in 2 files covered. (98.07%)

2 existing lines in 1 file now uncovered.

13356 of 13653 relevant lines covered (97.82%)

1638.94 hits per line