coreui / coreui-pro / 38080371065

96%

main: 94%

push

github

fix(PasswordInput): read the field's disabled state when the toggle is used (#1609)

The toggle button of a password input took the field's `disabled` state once, at init. A field the page disabled later could still be revealed, through the button or through `toggle()`, and a field it enabled later kept a disabled button.

`toggle()` now holds the rule. A field that matches `:disabled`, including one disabled through its fieldset, is not revealed, and a revealed one can always be hidden. The button only calls `toggle()` and does not change its own state on click, so it keeps focus. Focus on the field enables the button, because a field that takes focus is enabled. No `MutationObserver` is added: this small sync is read at the moment of use.

The Disabled section no longer asks for the `disabled` attribute on the toggle button, which the component builds itself, and the Methods row says a disabled field is not revealed. Each new spec fails under a mutation of its line.

7756 of 8342 branches covered (92.98%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

13363 of 13662 relevant lines covered (97.81%)

1635.57 hits per line