coreui / coreui-pro / 38082163590

96%

main: 94%

push

github

refactor(NumberInput): drop the MutationObserver and re-read the field when the user reaches for it (#1610)

NumberInput watched its field with a `MutationObserver` so the stepper buttons followed a script that changed `disabled`, `readonly`, `min`, `max` or `step` later. A button left disabled by an old state cannot be pressed, so without the observer the buttons have to re-read the field whenever the user reaches for them.

The observer goes. The buttons are recomputed when the pointer moves over the field's frame, when the frame is pressed with any pointer, and when the field takes focus or the user edits it (unchanged). With a mouse the hover runs before the press, so the first press works. A touch on a button that still looks disabled brings it up to date and the next touch steps. A press never steps a field it should not step, because the step reads the field itself, and a refused press leaves the buttons alone so a button activated by a screen reader keeps focus. `dispose()` now removes every frame listener by namespace.

The docs describe when the buttons catch up, in the Min, max and step section as well. Specs cover focus for each of `min`, `max` and `step`, hover and touch on the frame, a refused press keeping focus, and listeners gone after dispose; each fails under a mutation of its line.

7756 of 8342 branches covered (92.98%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

13364 of 13663 relevant lines covered (97.81%)

1635.76 hits per line