coreui / coreui-pro / 38079312246

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix: take the disabled state only from the disabled option (#1608)

Combobox, Autocomplete, MultiSelect, ChipSet and ChipInput, Chip, Rating and the date and time inputs (SectionInput) read their disabled state from two places: the `disabled` option and the markup. The markup source was a `.disabled` class and, in Combobox and MultiSelect, the native `disabled` attribute of the toggle button or the select. Each pair needed its own precedence rule. A JavaScript `false` lost to the class in one component and won in another, `data-coreui-disabled="false"` lost to it, and the pickers needed an exception so that a class on an adopted field did not disable the field alone.

The `disabled` option, given in JavaScript or as `data-coreui-disabled`, is now the only source. While the components live, they set the `.disabled` class, and the native attribute on a combobox toggle button or a multi select's select, from the option. `dispose()` gives the markup back from the class and attribute snapshots they already take. `toggleHostClass()`, which tracked who changed the class, goes, and the bundles shrink below their size before #1606 (bundlewatch: `coreui.min.js` 114.26 kB, `coreui.bundle.min.js` 120.43 kB).

A disabled multi select keeps disabling its select, so the form leaves it out of validation and of the submitted data and a `required` one does not block the submit. Combobox keeps setting the native `disabled` of a button toggle from the option. Chip Set does not write the class on its own element; it passes the option to its chips. In a chip input a single chip is disabled with `data-coreui-disabled="true"` on the chip, and every chip while the input is disabled. On dispose, a chip input gives a text field from the markup back its `disabled` and `readonly`, and a chip gives back the values of its host attributes, such as `aria-disabled`.

The specs that pinned the class or the attribute as input now check that the option decides and that `dispose()` gives ... (continued)

Coverage Stats

7752 of 8338 branches covered (92.97%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 8 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

13358 of 13657 relevant lines covered (97.81%)

1635.97 hits per line