coreui / coreui-pro / 38050410121

96%

main: 94%

push

github

fix: read a disabled class in the markup as disabled and take back only the one a component added (#1606)

The form components disagreed about what `class="disabled"` on the element means. Combobox, Chip and ChipInput read it as `disabled: true`. Rating and the date and time inputs (SectionInput) removed it at init and gave it back from the class snapshot on dispose, and that snapshot also removed a `.disabled` the page wrote after init. Autocomplete's data API skipped such an element, and a multi select only looked disabled while it kept working.

They now follow one model. A `.disabled` in the markup means `disabled: true` in Combobox, Autocomplete, MultiSelect, ChipInput, Chip, Rating, DateInput and TimeInput. Combobox now reads the class before it sets the native `disabled` of its toggle button, so a button with the class is disabled as well. `dispose()` undoes only the component's own change of the class. The new `toggleHostClass()` util, with JSDoc and specs, sets the class and returns whether the element carried it before the component changed it, or `null` while no such change is in effect. `.readonly` and the size class of Rating stay decided by the options.

SectionInput reads the class only when the options passed in JavaScript leave `disabled` unset. DateRangeInput and the date, date range and time pickers always set it for the fields they build or adopt, so a `.disabled` on an adopted field no longer disables that field while the picker stays enabled.

The Combobox, Autocomplete, MultiSelect, Rating, Date Input and Time Input pages say the class works in markup, and the migration guide describes the change for each. Every new spec fails with its source line reverted, measured by mutation.

A disabled multi select now also disables its native select, given back on dispose. The form leaves it out of validation and of the submitted data, as it does for the other disabled fields, so a required one no longer blocks the submit. A `disabled` att... (continued)

7786 of 8374 branches covered (92.98%)

Branch coverage included in aggregate %.

42 of 43 new or added lines in 8 files covered. (97.67%)

13385 of 13683 relevant lines covered (97.82%)

1635.95 hits per line