coreui / coreui-pro / 38046276030

96%

main: 94%

push

github

fix(LoadingButton): give the button back its markup on dispose (#1605)

`dispose()` left the `btn-loading` class on every button. When it ran while the button was loading it also left `is-loading` and the spinner, and while the button was stopping it left the spinner, which carries `role="img"` and `aria-label="Loading"`. Measured in Chromium on `v6-dev`, for example `<button class="btn-loading is-loading"><span class="btn-loading-spinner spinner-border" role="img" aria-label="Loading"></span>Save</button>` after disposing a loading button.

The button now records with `captureHostClasses()` whether it had `btn-loading` and a class attribute, and `restoreHostClasses()` gives that back, like the form components in #1604. `is-loading` stays out of that snapshot because it is a state the button drives: `dispose()` removes it the way `stop()` does. It also removes the spinner and cancels the loading message, whether the screen reader has read it yet or not. A `disabled` class it added while loading was already taken back by `_unblock()`, and the specs now check that no empty class attribute is left after it. The new specs fail on `v6-dev` in all three phases: idle, loading and stopping.

React and Vue cancel the same message when the component unmounts while loading, in coreui-react-pro and coreui-vue-pro on the branch of the same name.

7778 of 8366 branches covered (92.97%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

13377 of 13677 relevant lines covered (97.81%)

1631.99 hits per line