coreui / coreui-pro / 38044851171

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix: give form components' hosts back their class attribute on dispose (#1604)

Autocomplete, Combobox, MultiSelect, ChipInput, Calendar, Chip, PasswordStrength and OtpInput left `class=""` after `dispose()` on an element that had no class attribute, because removing the last class keeps the attribute. Measured in Chromium on `v6-dev`: for example `combobox-toggle` gave `class=""`, and so did `form-multi-select`, `form-control-group` and `calendars`. Each of them now snapshots the classes it owns and the attribute itself with `captureHostClasses()` at construction and gives them back with `restoreHostClasses()` on dispose, the way Rating and the pickers already do. RangeSlider swaps its own flag from #1602 for the same pair. Calendar lists the current `select-<selectionType>` class next to the five known ones, so an unknown type is taken back too.

In Autocomplete, Combobox, MultiSelect and ChipInput the `disabled` class stays outside the snapshot. The component removes it only when it added it, so a `disabled` class the page writes after init survives dispose, which the existing Combobox spec requires. That also fixes two leaks: MultiSelect left the `disabled` class it had added on the select, after dispose and after `setConfig({ disabled: false })`, and ChipInput left the one it had added on its element. Chip keeps `disabled` in its snapshot, as its class list already did. Calendar and PasswordStrength now keep a `calendars` or `password-strength` class the page wrote itself instead of removing it.

The new dispose specs fail on `v6-dev` and pass here. Measured growth of the built files with gzip -9: +161 B on `coreui.bundle.min.js` and +201 B on `coreui.esm.min.js`; bundlewatch passes.

Coverage Stats

7778 of 8366 branches covered (92.97%)

Branch coverage included in aggregate %.

48 of 48 new or added lines in 9 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

13371 of 13671 relevant lines covered (97.81%)

1632.62 hits per line