coreui / coreui-pro / 38042383778

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(RangeSlider): leave no empty class attribute on dispose (#1602)

dispose() could leave `class=""` on an element that had no class attribute, in two ways: it gave back the server state classes with `classList.add()` even when there were none, and an `add()` with no tokens writes an empty attribute; and it removed a validation state class applied during the element's life, and removing the last token leaves the attribute in place. Measured in Chromium on the built bundle before the change: `<div id="s" class=""></div>` after `dispose()`.

The component now remembers whether the element had a class attribute at construction and removes it when dispose() leaves it empty. An attribute the page wrote, even an empty one, stays. The dispose spec covers an element without state, one that got `validationState: 'invalid'`, and one that started with `class=""`.

Coverage Stats

7772 of 8362 branches covered (92.94%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

13354 of 13654 relevant lines covered (97.8%)

1629.69 hits per line