coreui / coreui-pro / 37853764964

96%

main: 94%

push

github

feat(Combobox): carry the value in a validated select and take a validation state (#1594)

Combobox carried its value in an <input type="hidden">, built only with a
name, so it could not be required or block a submit. It now always inserts a
hidden <select class="combobox-select input-group-ignore"> right after the
toggle, named only by the name option. In multiple mode it posts one key per
value, like a <select multiple>, instead of one comma-joined key; an empty
single combobox posts an empty value, an empty multiple one posts nothing.
Like any disabled field, a disabled combobox is not submitted.

- required makes an empty combobox block the submit. When a validation reports
  the select, it is laid along the start edge of the toggle at the toggle's
  height and stays 1px wide, so the browser shows its message there without
  widening the page, and the focus it gets goes to the toggle. Standing after
  the toggle keeps a wrapping <label> naming the toggle and leaves the
  input-group corners alone.
- validationState (with the deprecated invalid and valid aliases), or an
  .is-invalid/.is-valid class on the toggle in the markup, gives it a state,
  shown on the toggle as the class with the linked message in
  aria-describedby; the toggle is a button, so it takes neither aria-invalid
  nor aria-required. 'invalid' blocks the submit. A pick of a different value
  in the list drops a given state, a change from code keeps it, and
  setConfig({ validationState }) sets it again without rebuilding.
- What a validation reports shows the same way, a message can be named in
  data-coreui-invalid-feedback on the toggle, and a native form reset puts
  back the value the combobox started with. The Form plugin leaves both the
  select and the search field to the combobox.
- The form validation util gains alignValueField, finds the messages of a
  combobox from its toggle, and writeValueField marks the options it builds
  selected by default, so a native reset lea... (continued)

7590 of 8171 branches covered (92.89%)

Branch coverage included in aggregate %.

89 of 90 new or added lines in 2 files covered. (98.89%)

13139 of 13436 relevant lines covered (97.79%)

1625.92 hits per line