coreui / coreui-pro / 37858285712

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(OTPInput): take a validation state and stop watching the DOM for one (#1595)

OTPInput had no option for its state. A page could show one only by writing
.is-invalid or aria-invalid on the group, or .is-invalid on a slot, and a
MutationObserver followed those writes for the life of the component.

- validationState ('valid', 'invalid' or a state of $form-validation-states),
  from the option, data-coreui-validation-state or setConfig, sets the state.
  An .is-invalid/.is-valid class on the .form-otp element or on a slot in the
  markup is read once at start and moves to the group, since the code is one
  value; dispose gives it back where it was. The group shows the state as
  .is-{state}; while it is 'invalid' every slot carries aria-invalid="true"
  with the message in aria-describedby, and the code blocks the submit with
  the message text unless it is disabled or read-only.
- The user's next change of the code (typing, a deletion, a paste, an
  autofill) drops a given state before the change events. A change from code
  keeps it, and so does a keystroke that leaves the code as it was. A
  setConfig with only validationState updates the state without repainting
  the slots.
- aria-invalid on the group or a slot is not read, a class written after start
  changes nothing, and the observer is gone. Reports come from the value field
  through followUserValidity, and the form plugin and the stepper leave the
  value field and the slots, also slots added after start, to the component.
- A native form reset puts back the code the field started with: the value
  option when it was given, otherwise the slots' own markup. Slots seeded from
  value were left empty before. The reset also recomputes the linear tab
  order and the length of the first slot.
- A paste into a read-only code is ignored; it used to change the code.
- The value field is built with createValueField and configureValueField and
  sends input and change on every change of the code.

... (continued)

Coverage Stats

7610 of 8191 branches covered (92.91%)

Branch coverage included in aggregate %.

82 of 82 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

13150 of 13448 relevant lines covered (97.78%)

1627.33 hits per line