coreui / coreui-pro / 37842834951

96%

main: 94%

push

github

feat(ChipInput): carry the chips in a validated field and take a validation state (#1593)

Chip Input carried its chips in an <input type="hidden">, which the browser
leaves out of validation, so it could not be required or block a submit. The
chips now travel in a hidden <textarea> laid over the frame, with the same
comma-separated value and the id and name options on it. Like any disabled
field, a disabled chip input is no longer submitted.

- required makes an empty chip input block the submit; the browser's message
  shows over the field and the focus it gives the field goes to the text input.
- validationState (with the deprecated invalid and valid aliases), or an
  .is-invalid/.is-valid class in the markup, gives it a state, shown on the
  frame and as aria-invalid with the linked message on the text input;
  'invalid' blocks the submit. A user change of the chips drops a given state,
  a change from code keeps it, and setConfig({ validationState }) sets it again
  without rebuilding.
- What a validation reports shows the same way, a message can be named in
  data-coreui-invalid-feedback on the chip input, and a native form reset puts
  back the chips the field started with, the same elements, writes them into
  the field and fires change.coreui.chip-input when they changed.
- ChipSet sends its change event through _triggerChange(), and the form
  validation util gains createValueField, configureValueField, writeValueField
  and dispatchValueChange for the components that carry their value in a
  hidden field. Its feedback lookup treats a .chip-input as the element the
  layout places the messages around, and a frame that is a .form-field child
  as reaching that field.

Raises the bundlewatch ceilings of the six JS bundles. Measured with gzip -9
on both builds, the change adds 2.57 kB to coreui.bundle.js, 2.56 kB to
coreui.esm.js and 2.58 kB to coreui.js, and 1.04 to 1.06 kB to their minified
builds.

7550 of 8130 branches covered (92.87%)

Branch coverage included in aggregate %.

163 of 164 new or added lines in 3 files covered. (99.39%)

13070 of 13366 relevant lines covered (97.79%)

1629.12 hits per line