coreui / coreui-pro / 37542198501

96%

main: 94%

push

github

fix(DatePicker,DateRangePicker,TimePicker): announce the state class the page writes on the picker (#1580)

* fix(DatePicker,DateRangePicker,TimePicker): announce the state class the page writes on the picker

An .is-invalid class on the picker element styled the frame and showed the
message after it, but no section of the field carried aria-invalid, even with
aria-invalid="true" written next to the class, so a screen reader heard
neither the state nor the message. The picker now watches its element and,
while it carries .is-invalid or aria-invalid="true", marks its field invalid
the way the date range marks its ends: the sections carry aria-invalid, are
described by the message and never turn valid. When the page drops the class,
the field follows.

getFeedbackIds() also finds the message after an element around the control
that carries .is-invalid, the rule the stylesheet applies, so the message
after a date range picker outside a .form-field is linked too, and so is the
one after an input group the page marks invalid.

* chore: raise the JavaScript bundle budgets

Announcing the state class on the pickers adds 0.43 kB to coreui.bundle.js,
0.24 kB to coreui.bundle.min.js, 0.35 kB to coreui.esm.js, 0.25 kB to
coreui.esm.min.js, 0.43 kB to coreui.js and 0.24 kB to coreui.min.js
(bundlewatch, gzip, fa9c205e2 against 3fd72b8f8). Four of them went over
their budget and the other two kept 20 and 30 bytes, so each budget goes up
far enough to leave room: by 0.5 kB for the unminified bundles and 0.25 kB
for the minified ones.

* fix(DatePicker,DateRangePicker,TimePicker): follow every change of the state markers

The picker only told its field when the combined state flipped, so moving
from aria-invalid="true" to the .is-invalid class, or back, left the
sections without the message the class had just shown, or pointing at one it
had just hidden. It now passes the state on at every change of either
marker. The docs say that aria-invalid="true" alone marks th... (continued)

7239 of 7804 branches covered (92.76%)

Branch coverage included in aggregate %.

28 of 28 new or added lines in 6 files covered. (100.0%)

12531 of 12825 relevant lines covered (97.71%)

1595.62 hits per line