coreui / coreui-pro / 37598297090

96%

main: 94%

push

github

fix(OTPInput): validate the code as one value and announce it on every slot (#1583)

* fix(OTPInput): validate the code as one value and announce it on every slot

The code lived in an <input type="hidden">, which the browser leaves out of
validation, and required went on every slot, so each empty slot was checked
on its own, a partial code that was not required went through, and nothing
linked the message to the slots. The stylesheet coloured a slot marked
invalid but never showed the message after the group.

The value now sits in a text input laid invisibly over the group, with
tabindex -1, aria-hidden, required and a pattern for the full length of the
code; focus the browser or the form plugin gives it moves to the first empty
slot. Once a validation reports it, every slot carries aria-invalid and the
message after the group, which getFeedbackIds() now finds for any control of
a .form-otp, until the code is complete or the form resets. The stylesheet
colours every slot and shows the message after the group when the group, its
value field or a slot is marked, or when the browser flags the value field.

* test(OTPInput): cover the label that points at the value input

* fix(OTPInput): keep the value field, its state and every instance's reset

setConfig() replaced the value field and lost the state the form plugin and
the browser had put on it, while the slots stayed marked invalid; it now
updates the field in place. Each instance listens for a reset of whatever
form it sits in when the reset happens, with its own handler, so dispose()
no longer drops the listeners of the other codes in the form and a field
moved into a form still resets. The slots carry aria-required, since the
value input that holds required is hidden from assistive technologies. The
success message after the group waits until nothing in it is invalid,
because the form plugin marks each slot valid on its own, and the slot and
group rules share one mixin.

* chore: raise the JavaSc... (continued)

7282 of 7850 branches covered (92.76%)

Branch coverage included in aggregate %.

98 of 98 new or added lines in 2 files covered. (100.0%)

12608 of 12902 relevant lines covered (97.72%)

1589.98 hits per line