coreui / coreui-pro / 37536443348

96%

main: 94%

push

github

fix(DateInput,TimeInput): describe the sections with the error message shown for the field (#1579)

* fix(DateInput,TimeInput): describe the sections with the error message shown for the field

While a date or time field is invalid, its sections are now described by the
.invalid-feedback or .invalid-tooltip the stylesheet shows for it: after the
field, after the frame around it (date picker, date range) or in its
.form-field. Before, a screen reader heard that the field was invalid but not
why, unless the page wired aria-describedby itself; the form plugin linked
nothing either, because it looked for the message around the hidden value
field.

getFeedbackIds() now reads the layout of a .form-date-time value field from
the field itself, so the form plugin, the stepper and the component find the
same message, the plugin announces it instead of the browser's text when focus
already sits on the field, and data-coreui-invalid-feedback on the field names
a message placed elsewhere.

* test(DateInput): cover a message added on errorChange and one inside a floating label

The contract spec now requires the message to be shown in every date layout,
so a layout where the stylesheet hides it can no longer pass by linking
nothing. The docs say when a message the page adds later is picked up, and
that data-coreui-invalid-feedback is read from the date input or time input
element, which the pickers and the date range build themselves.

* chore: raise the budgets of the minified bundles

Linking the error message to the sections of a date field adds 0.12 kB to
coreui.bundle.min.js, 0.13 kB to coreui.esm.min.js and 0.12 kB to
coreui.min.js (bundlewatch, gzip, d3b68fbdd against 1b5a58cf5). The esm build
went over its 108 kB budget and the other two kept 30 and 40 bytes, so each
budget goes up by 0.25 kB.

* fix(forms): leave a hidden message out of the description of a control

getFeedbackIds() skips an .invalid-feedback or .invalid-tooltip with the
hidden attribute o... (continued)

7225 of 7789 branches covered (92.76%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 2 files covered. (100.0%)

12507 of 12801 relevant lines covered (97.7%)

1591.78 hits per line