coreui / coreui-pro / 37477120365

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(DateInput,TimeInput): let a required field block the form (#1575)

The value of a date or time field lived in an <input type="hidden">, and
the browser leaves hidden inputs out of constraint validation. A required
field that was empty, incomplete or held a rejected date therefore did not
stop the submit: form.checkValidity() stayed true, the browser sent the
form, and neither the form plugin nor the stepper saw the field, while the
component painted it invalid. Measured in Chromium on a
data-coreui-validate novalidate form with an empty required field: the
submit went through.

The value now lives in a <textarea> laid invisibly over the field
(position absolute over its box, opacity 0, pointer-events none), with
tabindex="-1", aria-hidden="true" and autocomplete="off", the way the
multi select lays its native select. A textarea, because a single-line
text input counts as a field that blocks implicit submission: measured,
Enter in the only text input of a form without a submit button stopped
submitting it with a text input and submits it again with a textarea. The
textarea keeps required and disabled, takes readonly, so a read-only field
stays out of validation, and its default value is what reset() restores,
the initial date under the current format and limits, so a native reset
puts it back at once and a submit in the same task judges it; with an
empty default it blocked such a submit, measured.

When the browser or the form plugin puts focus on it, the field hands it
to its first empty section, as a click does; a click on a section no
longer reaches a wrapping <label>, which would hand focus to the textarea.
When a validation reports it invalid (the stepper, the form plugin,
checkValidity()), the field marks itself invalid as it does after a
submit and keeps its success state for when the date is valid again;
EventHandler learns the invalid event for that. When the submitted value
changes after the field is built, the textarea fires input and ch... (continued)

Coverage Stats

7215 of 7779 branches covered (92.75%)

Branch coverage included in aggregate %.

31 of 31 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

12501 of 12795 relevant lines covered (97.7%)

1590.38 hits per line