IJHack / QtPass / 37308126470

92%

push

github

Build without warnings on GCC 16 (#1960)

* Build without warnings on GCC 16

A fresh build on GCC 16.2 / Qt 6.11.2 printed 72 warnings:

- 67 x -Wsfinae-incomplete, all in Qt's own headers (qchar.h, qbitarray.h
  met through libstdc++'s range_access.h); nothing in QtPass to change.
  qtpass.pri turns the new check off for GCC 16 and newer only; older GCC
  and clang do not know the flag.
- ImitatePass::pullBeforeReencrypt ignored the exit status of
  `git ls-files --unmerged`; a failed check counted as "no unmerged files"
  and re-encryption went ahead on a store the pull may have left in a
  merge. Unknown is not clean now: it refuses and says why.
- RealPass removing a linked entry ignored the `git ls-files` and
  `git rm --cached` results; a failed step no longer leads into a commit
  of nothing, the removal ends as the untracked case does.
- tst_mainwindow checks qWaitForWindowActive() before sending Ctrl+M;
  tst_settings loops over a QStringList instead of binding const QString&
  to temporaries from const char*.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* RealPass: report git failing to forget a removed link

The link is removed before git is asked to forget it. When `git ls-files`
or `git rm --cached` then failed, the removal still finished as a clean
one, leaving git tracking a link that is gone without a word. It now says
so ("The link ... was removed, but git could not record it: <git's
reason>") through critical() and processErrorExit(), and still finishes
the removal so the tree refreshes; nothing is committed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* docs: clarify re-encryption pull checks, linked-folder removal, and profile tests

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@u... (continued)

15 of 18 new or added lines in 2 files covered. (83.33%)

9078 of 9773 relevant lines covered (92.89%)

191.62 hits per line