IJHack / QtPass / 37313330621

93%

push

github

PasswordDialog: a save that never reports must not trap the dialog (#1965)

#1951's review follow-up refused Cancel, Esc and the close button while
an insert was in flight, so a failure could still hand back the entry.
But a save that never reports back (gpg or pass waiting on an unanswered
PIN prompt, git commit signing, the process queue held up behind a
hanging pull) then left quitting QtPass as the only way out, losing the
entry anyway.

Cancel stays enabled while saving; Cancel, Esc and closing ask "The entry
is still being saved. Close the dialog anyway? If saving then fails,
what you typed is lost." No keeps waiting. Yes closes; the dialog stops
listening, and whatever the insert reports later the main window shows
as before. No timeout: a real PIN prompt can take a while.


Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

9081 of 9776 relevant lines covered (92.89%)

191.51 hits per line