IJHack / QtPass / 37306626272

93%

push

github

gpg errors: an unusable key is not a missing one (#1961)

* gpg errors: an unusable key is not a missing one

Through pass (no --status-fd) gpg only says "Unusable public key" for a
recipient key that is present but cannot encrypt: expired, revoked or
without an encryption subkey. gpgErrorMessage() grouped that with "No
public key" and told the user the key was not found and to check it was
imported. Hit while testing #1951: a .gpg-id still listing a key that
expired in 2017.

It gets its own message now: the key cannot be used; renew or replace it,
or remove it from .gpg-id. The status-token cases (KEYEXPIRED,
KEYREVOKED, INV_RECP) keep their more precise messages. One new string.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* gpg errors: "unusable" can also mean "not trusted"

gpg prints "Unusable public key" for a key that is not trusted as well
("There is no assurance this key belongs to the named user"), not only
for one that expired, was revoked or has no encryption subkey. The
message lists all four and points to gpg's own lines shown below it,
instead of telling the user to renew or replace a key that may only need
trust.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

9069 of 9761 relevant lines covered (92.91%)

191.84 hits per line