orneryd / NornicDB / 37228801453

89%

Build Type

push

github

Committed by orneryd

Commit Message

fix(cypher): reject incomplete statements and stored expression text (#514)

Neo4j rejects a statement that ends inside a clause and never stores
query text as property data. NornicDB accepted both, diverging from
Neo4j 5.26.30 on the statements listed in the #514 reopen:

- CREATE — wrote an unlabeled node, now a SyntaxError with nothing written
- MATCH (n:X) / MATCH (n) WITH n / CREATE (n:Z) WITH n / OPTIONAL MATCH /
  WITH n, count(m) AS c — now SyntaxErrors (reading clause with nothing
  after it); the old UNWIND-only completeness rule covers all four
- MATCH (m:BFn) OPTIONAL MATCH (n)-[:CALLS]->(m {uid: 'b'}) and
  MATCH (n:PDRecord {id: identifier}) — SyntaxError via the same rule
- create.go — wrote an unlabeled node, now a SyntaxError (CREATE must be
  followed by a pattern or a named-path assignment)
- CALL — returned ProcedureNotFound, now a SyntaxError
- CREATE (:T {v: <expr>}) and FOREACH (x IN ['a'] | CREATE (:F {v: y}))
  stored the expression's source text as the value; an unevaluable CREATE
  property-map expression is now a SyntaxError. Genuine evaluation errors
  (1 / 0) keep their ArithmeticError, and expressions the row evaluator
  resolves (pattern bindings, loop bindings) are unaffected.
- CREATE PROMOTION PROFILE without a name — the knowledge-policy DDL parse
  error is now classified as Neo.ClientError.Statement.SyntaxError on
  every route

The completeness rule runs after syntax validation so malformed text keeps
the parser's own error, and the clause scanner skips WITH inside
expressions (STARTS WITH, ENDS WITH, IS :: TIME WITH TIME ZONE), including
across comments. WITH EMBEDDING remains a valid terminator.

Tests:
- pkg/cypher/gh514_incomplete_statements_test.go: all 13 statements are
  SyntaxErrors with nothing written, plus positive controls for evaluable
  CREATE expressions
- existing tests that pinned the old behavior (MATCH with no RETURN,
  OPTIONAL MATCH with no RETURN, unbound CREATE identifiers stored as
  text)... (continued)

Coverage Stats

135 of 168 new or added lines in 3 files covered. (80.36%)

70 existing lines in 16 files now uncovered.

180613 of 207611 relevant lines covered (87.0%)

1.02 hits per line