orneryd / NornicDB

89%

main: 89%

LAST BUILD ON BRANCH fix/where-rel-existence-and-delete-guard

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• admin-import
• async-config
• bolt-over-ws
• codex/4902-executewrite-delete
• codex/5122-local-analyze-proof
• codex/eshu-repo-edge-expansion
• codex/recovery-corruption-chunking
• codex/search-startup-mode
• codex/v111-match-merge-on-create-route
• feature/unique-merge-conflict-surfacing-209
• fix/fail-loud-multiclause
• fix/rel-source-uid-in-index-seed
• fix/where-rel-existence-and-delete-guard
• main
• otel
• perf/k8s-tier2-canonical-write-followups
• property-key-index
• release-1-1-0
• search-index-flags
• si-adj-api
• substrate-layer
• test/bound-delete-fastpath-coverage
• ui-readiness

fix(cypher): correctly evaluate relationship-existence predicates, resolve OPTIONAL MATCH rel vars, and guard non-detach DELETE

Three correctness fixes in the Cypher WHERE/DELETE mutation paths, the root
cause behind eshu-hq/eshu#5147.

1. Relationship-existence predicates in WHERE/COUNT/EXISTS were mis-evaluated
   for bracket-less and bracketed-undirected patterns. (n)--(), (n)-->(),
   (n)<--(), and (n)-[r]-() fell through the pattern gate to a default-true
   branch, so NOT (n)--() matched nothing and COUNT { (n)--() } = 0 matched
   every node. containsRelExistencePattern/bareRelDirection now classify these
   and route them to the existing relationship evaluator.

2. A relationship variable bound by an embedded OPTIONAL MATCH resolved to nil
   in the internal MATCH...RETURN probe that executeDelete/executeSet/
   executeRemove build, because parseTraversalPatternStateMachine locates the
   relationship bracket by scanning from the first node group's closing paren
   rather than searching for -[. executeMatch now routes an embedded
   OPTIONAL MATCH through executeCompoundMatchOptionalMatch. Also fixed a
   second, independent gap: executeRemove/applyRemoveToMatchedRows had no
   *storage.Edge support and duplicated rows when binding 2+ node variables.

3. A non-DETACH DELETE of a node that still has relationships silently
   cascade-deleted its edges. It now errors (openCypher/Neo4j semantics) unless
   the residual edges are themselves being deleted in the same statement.
   Behavior change documented in CHANGELOG.md.

Neo4j compatibility suite stays green; the previously masked
Delete_chunks_with_OPTIONAL_MATCH test is restored to a plain DELETE as the
green proof.