coreui / coreui-pro / 37226005995

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(Transfer): announce moves through announce() (#1559)

* fix(announce): ignore a wait left by another clock

A region made ready on one clock and used on another, such as a test file
mixing real and fake timers, made the queue wait seconds, because the stored
time came from the first clock. A wait longer than the longest hold, 500 ms,
now counts as stale and the region is ready at once.

* feat(Transfer): announce moves through announce()

Transfer kept a `.transfer-announcer` region with `role="status"` and wrote
each move into it. It now calls announce() with its element as `context`, so
every move is a message of its own, including the same move made twice, and
a transfer inside a modal dialog announces from inside it. Every `{count}`
and `{title}` in `ariaMovedAnnouncement` is replaced, as the docs say; only
the first one was. dispose() has no region to remove.

* fix(announce): tell clocks apart by the clock, not by the size of the wait

A stored ready time counted as left by another clock only when it was more
than 600 ms away, so a test file whose page was young enough still waited on
a time from its real clock under fake timers, and on a clock with fractions
of a millisecond the 500 ms hold after a close could compare as 500.0000004
and be dropped. Every stored time now carries the performance.now function
it was read from; a time read from another one, which fake timers and mocks
swap in, counts as long past. No threshold is left.

* fix(Transfer): announce before the change listeners, keep $ in titles

The move is now announced before `moved.coreui.transfer` and
`change.coreui.transfer` fire, so a message a change handler sends comes
after it, and `{title}` is replaced through a function, so `$$` or `$&` in a
title stays as written. The WCAG check for 4.1.3 looks for the message in the
live region of the page instead of the removed `.transfer-announcer`. The
accessibility page notes that modals hiding the page with aria-hidden or
inert h... (continued)

Coverage Stats

6903 of 7456 branches covered (92.58%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

12058 of 12351 relevant lines covered (97.63%)

1485.33 hits per line