coreui / coreui-pro / 37223590816

96%

main: 94%

push

github

feat(Toaster): hold announcements while a modal dialog closes (#1558)

* feat(Toaster): hold announcements while a modal dialog closes

A modal dialog stays modal while it plays its closing transition, so a
message added then went to its regions and left with it, and VoiceOver
skipped a message added as the dialog closed, in Safari when focus went back
to the opening button and in Chrome when it went to the page, while one added
half a second later was read in both.

The queue now waits while the modal dialog a message would go to carries
`.hiding`, which Modal, Offcanvas, Dialog and Drawer set during the exit, and
a MutationObserver on the `open` attribute holds the regions that take over
for 500 ms after any dialog closes. The observer runs before a queued
insertion, so a toast added from `hidden.coreui.modal`, which fires before
the native close event, waits as well.

* chore: raise three JS bundle budgets for the announcement hold

Measured against origin/v6-dev with gzip -9 on both builds, holding
announcements around a closing dialog adds 380 to 394 B to the unminified
bundles and 155 to 158 B to the minified ones. coreui.esm.js and coreui.js
went over their ceilings and coreui.bundle.js kept 10 B, so each goes up by
0.25 KB; the minified ceilings still leave 0.21 to 0.33 KB.

* fix(Toaster): watch dialogs from page load so the first toast waits too

The observer started with the first announce(), after the close it was meant
to see, so the first toast of a page added from hidden.coreui.modal went in
100 ms after the close, the timing VoiceOver skipped. It now starts when the
module loads and only notes the hold on the host that takes over, the next
modal dialog or the page; regions created later honour it, and a hold more
than 500 ms away, left by another clock such as a test's, is ignored. A
dialog holding focus that plays its closing transition holds the queue too,
modal or not, and the observer schedules the flush itself once the hold ends.
... (continued)

6903 of 7456 branches covered (92.58%)

Branch coverage included in aggregate %.

29 of 29 new or added lines in 1 file covered. (100.0%)

12066 of 12357 relevant lines covered (97.65%)

1483.24 hits per line