orneryd / NornicDB / 37215434766

89%

Build Type

push

github

Committed by orneryd

Commit Message

fix(storage): label reads skip other databases' nodes before reading them (#851)

The label index key has no database in it, so a label scan visits the
label's entries in every database. Each entry's node was read (txn.Get)
and decoded before NamespacedEngine dropped the ones outside its
database: a 1,000-node :Person scan took 2.5 ms alone and 479 ms with
100,000 :Person nodes in another database.

ScopedLabelNodeReader adds scoped forms of the label reads
(GetNodesByLabel, GetFirstNodeByLabel, StreamNodesByLabelProjected,
GetNodesByLabelVisibleAt). BadgerEngine skips an entry outside the
scope right after resolving its node ID, before any read; WALEngine and
AsyncEngine pass the scope down (AsyncEngine also scopes its pending
overlay) and fall back to the unscoped read for inner engines without
it; NamespacedEngine reads with its own prefix and still filters. A
transaction pinned to a database scopes its label scans to it.

Test fakes that embed MemoryEngine and override a label read now
override its scoped form too, since the wrappers delegate through it.
The unused streamNodesByLabelFromPhysicalSnapshot wrapper is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

106 of 109 new or added lines in 10 files covered. (97.25%)

32 existing lines in 12 files now uncovered.

179235 of 206293 relevant lines covered (86.88%)

1.02 hits per line