orneryd / NornicDB / 37215181436

89%

Build Type

push

github

Committed by orneryd

Commit Message

fix(storage): bound every range scan to its prefix (#850)

Badger's reverse iterator ignores IteratorOptions.Prefix, and a forward
iterator without one keeps prefetching past the range: either skipped
every deleted key beyond the range on each Seek and Next, ValidForPrefix
only ending the caller's loop afterwards. DROP DATABASE deletes the
dropped database's numeric-ID MVCC adjacency keys; they sort below the
adjacency prefixes of nodes created later, so each relationship read of
such a node walked all of them, and DETACH DELETE of 100k edgeless
nodes went from 6.4 s to 2,172 s.

Every range scan is now forward with a Prefix bound. The MVCC adjacency
scan meets each edge's versions oldest first and keeps the last one at
or before the read version, returning edges newest first as before.
Lookups that want the greatest keys first (the MVCC record at or before
a version, the temporal-history lookups) go through descendingPrefixKeys:
the range's two lowest keys are found forward and visited by forward
seeks, and the reverse iterator is only advanced above them, so its
read-ahead never leaves the range.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

100 of 100 new or added lines in 7 files covered. (100.0%)

30 existing lines in 13 files now uncovered.

179157 of 206229 relevant lines covered (86.87%)

1.02 hits per line